Looks good. Could you also update the patch file while documents these modifications? You should be able to just add the missing assignment in place without having to redo the patch:

Please do so by amending the commit with git commit --amend to keep both changes together (see PR workflow).

I'll try and get it sorted tomorrow. Sorry if it takes me a bit, this is quite literally my first time doing a PR for anything

Why not cherry-pick? This causes a problem in Goost as well (where some polypartition functions are exposed in Godot 3.x):

https://github.com/goostengine/goost/blob/52ebb330aa6752552bd9ab1cee0f854e57657992/core/math/geometry/2d/poly/decomp/polypartition/poly_decomp_polypartition.cpp#L100-L104

Why not cherry-pick? This causes a problem in Goost as well (where some polypartition functions are exposed in Godot 3.x):

goostengine/goost@52ebb33/core/math/geometry/2d/poly/decomp/polypartition/poly_decomp_polypartition.cpp#L100-L104

#48921 wasn't cherry-picked, so the regression doesn't seem to exist in 3.x.

I don't see any missing iter* = in thirdparty/misc/triangulator.cpp in 3.x.

Ok, I think that did it.

Thanks! And congrats for your first merged Godot contribution 🎉

One little followup - I notice in the commit log it says "Nova" with no avatar and no link to my profile. I think I might have not linked my ssh keys up with github properly or something... Not sure what happened there.

You authored that commit without any email information indeed, see https://github.com/godotengine/godot/commit/36ae916c09181c252e679d6d3bae38ac7a446204.patch

You might want to fix your Git config for future commits so that you can be identified as the author.

Oh well... I'll fix it for next time I guess.